Ruby Critic

Updated 2025-06-23 20:19:53 -0300
app/models/webhook / api_client.rb

32 lines of codes
4 methods
5.7 complexity/method
3 churn
22.81 complexity
0 duplications
class Webhook::ApiClient                                        IrresponsibleModule              
      Webhook::ApiClient has no descriptive comment          
  
  def initialize(webhook)
    @webhook = webhook
    @connection = create_connection
  end

  def create_connection
    Faraday.new(@webhook.url) do |faraday|
      faraday.options.timeout = 5                                        FeatureEnvy              
      Webhook::ApiClient#create_connection refers to 'faraday' more than self (maybe move it to another class?)              Locations:                  0                  1                  
  
      faraday.headers = { 'Content-Type': 'application/json' }                                        FeatureEnvy              
      Webhook::ApiClient#create_connection refers to 'faraday' more than self (maybe move it to another class?)              Locations:                  0                  1                  
  
    end
  end

  def post_request
    response = @connection.post

    if response.success?                                        FeatureEnvy              
      Webhook::ApiClient#post_request refers to 'response' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
      { ok: response.status, request: response }                                        DuplicateMethodCall              
      Webhook::ApiClient#post_request calls 'response.status' 2 times              Locations:                  0                  1                  
  
                                        FeatureEnvy              
      Webhook::ApiClient#post_request refers to 'response' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
    else
      logger_error('Failed to validate webhook URL', response)
      { error: "Invalid or unreachable URL (status: #{response.status})", request: response }                                        DuplicateMethodCall              
      Webhook::ApiClient#post_request calls 'response.status' 2 times              Locations:                  0                  1                  
  
                                        FeatureEnvy              
      Webhook::ApiClient#post_request refers to 'response' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
    end
  end

  private

  def logger_error(message, response)
    Rails.logger.error "Webhook Api Client error: #{message} - Webhook #{@webhook.id || 'new'}"                                        DuplicateMethodCall              
      Webhook::ApiClient#logger_error calls 'Rails.logger' 3 times              Locations:                  0                  1                  2                  
  
    Rails.logger.error "Webhook: #{@webhook.inspect}"                                        DuplicateMethodCall              
      Webhook::ApiClient#logger_error calls 'Rails.logger' 3 times              Locations:                  0                  1                  2                  
  
    Rails.logger.error "Request: #{response.inspect}"                                        DuplicateMethodCall              
      Webhook::ApiClient#logger_error calls 'Rails.logger' 3 times              Locations:                  0                  1                  2                  
  
  end
end